netdev - Re: [PATCH v5 4/7] ptp: ptp_vmclock: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260112194619.70ed3a24@kernel.org>
Date: Mon, 12 Jan 2026 19:46:19 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Chalios, Babis" <bchalios@...zon.es>
Cc: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 "dwmw2@...radead.org" <dwmw2@...radead.org>, "andrew+netdev@...n.ch"
 <andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "devicetree@...r.kernel.org"
 <devicetree@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "Graf (AWS), Alexander" <graf@...zon.de>,
 "mzxreary@...inter.de" <mzxreary@...inter.de>, "Cali, Marco"
 <xmarcalx@...zon.co.uk>, "Woodhouse, David" <dwmw@...zon.co.uk>
Subject: Re: [PATCH v5 4/7] ptp: ptp_vmclock: Add device tree support

On Wed, 7 Jan 2026 13:26:01 +0000 Chalios, Babis wrote:
> +static int vmclock_setup_notification(struct device *dev,
> +				      struct vmclock_state *st)
> +{
> +	/* The device does not support notifications. Nothing else to do */
> +	if (!(le64_to_cpu(st->clk->flags) & VMCLOCK_FLAG_NOTIFICATION_PRESENT))
> +		return 0;
> +
> +	if (has_acpi_companion(dev)) {
> +		return vmclock_setup_acpi_notification(dev);
> +	} else {
> +		return vmclock_setup_of_notification(dev);
> +	}
> +
> +}
> +
> +
>  static void vmclock_put_idx(void *data)

Please run checkpatch.

CHECK: Blank lines aren't necessary before a close brace '}'
#109: FILE: drivers/ptp/ptp_vmclock.c:636:
+
+}

CHECK: Please don't use multiple blank lines
#111: FILE: drivers/ptp/ptp_vmclock.c:638:
+
+