netdev - Re: [PATCH] hinic3: add WQ_PERCPU to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260114085108.2361-1-gongfan1@huawei.com>
Date: Wed, 14 Jan 2026 16:51:08 +0800
From: Fan Gong <gongfan1@...wei.com>
To: <marco.crivellari@...e.com>
CC: <andrew+netdev@...n.ch>, <bigeasy@...utronix.de>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <frederic@...nel.org>, <gongfan1@...wei.com>,
	<jiangshanlai@...il.com>, <kuba@...nel.org>, <linux-kernel@...r.kernel.org>,
	<mhocko@...e.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<tj@...nel.org>
Subject: Re: [PATCH] hinic3: add WQ_PERCPU to alloc_workqueue users

>  drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c   | 2 +-
>  drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c b/drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c
> index 01686472985b..1ecc2aca1e35 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c
> @@ -655,7 +655,7 @@ int hinic3_aeqs_init(struct hinic3_hwdev *hwdev, u16 num_aeqs,
>  	hwdev->aeqs = aeqs;
>  	aeqs->hwdev = hwdev;
>  	aeqs->num_aeqs = num_aeqs;
> -	aeqs->workq = alloc_workqueue(HINIC3_EQS_WQ_NAME, WQ_MEM_RECLAIM,
> +	aeqs->workq = alloc_workqueue(HINIC3_EQS_WQ_NAME, WQ_MEM_RECLAIM | WQ_PERCPU,
>  				      HINIC3_MAX_AEQS);
>  	if (!aeqs->workq) {
>  		dev_err(hwdev->dev, "Failed to initialize aeq workqueue\n");
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c
> index 95a213133be9..3696ab3f1a1b 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c
> @@ -472,7 +472,7 @@ int hinic3_init_hwdev(struct pci_dev *pdev)
>  		goto err_free_hwdev;
>  	}
>  
> -	hwdev->workq = alloc_workqueue(HINIC3_HWDEV_WQ_NAME, WQ_MEM_RECLAIM,
> +	hwdev->workq = alloc_workqueue(HINIC3_HWDEV_WQ_NAME, WQ_MEM_RECLAIM | WQ_PERCPU,
>  				       HINIC3_WQ_MAX_REQ);
>  	if (!hwdev->workq) {
>  		dev_err(hwdev->dev, "Failed to alloc hardware workq\n");

Thanks for your change.

Reviewed-by: Fan Gong <gongfan1@...wei.com>