netdev - Re: [PATCH net-next V2 0/3] Introduce and use netif_xmit_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWdfgaA2543svwNi@horms.kernel.org>
Date: Wed, 14 Jan 2026 09:18:57 +0000
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Jian Shen <shenjian15@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>,
	Jijie Shao <shaojijie@...wei.com>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
	Gal Pressman <gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>,
	Shahar Shitrit <shshitrit@...dia.com>,
	Yael Chemla <ychemla@...dia.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH net-next V2 0/3] Introduce and use
 netif_xmit_timeout_ms() helper

On Mon, Jan 12, 2026 at 11:16:20AM +0200, Tariq Toukan wrote:
> Hi,
> 
> This is V2, find V1 here:
> https://lore.kernel.org/all/1764054776-1308696-1-git-send-email-tariqt@nvidia.com/
> 
> This series by Shahar introduces a new helper function
> netif_xmit_timeout_ms() to check if a TX queue has timed out and report
> the timeout duration.
> It also encapsulates the check for whether the TX queue is stopped.
> 
> Replace duplicated open-coded timeout check in hns3 driver with the new
> helper.
> 
> For mlx5e, refine the TX timeout recovery flow to act only on SQs whose
> transmit timestamp indicates an actual timeout, as determined by the
> helper. This prevents unnecessary channel reopen events caused by
> attempting recovery on queues that are merely stopped but not truly
> timed out.
> 
> Regards,
> Tariq
> 
> V2:
> - Rebase.
> - Move helper to include/net/netdev_queues.h.
> - Remove output paramter trans_start from the new helper.
> - Revert the code in dev_watchdog to not use the helper.
> - Fix the helper name in commit message.

Thanks for the updates.
I agree the address the review of v1.
And, overall, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>