netdev - Re: [PATCH net-next] net/sched: cake: avoid separate allocation of struct cake_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ecns1n3f.fsf@toke.dk>
Date: Wed, 14 Jan 2026 11:54:12 +0100
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Paolo Abeni
 <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Jakub
 Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 cake@...ts.bufferbloat.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: cake: avoid separate allocation of
 struct cake_sched_config

Eric Dumazet <edumazet@...gle.com> writes:

> On Tue, Jan 13, 2026 at 3:32 PM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>>
>> Paolo pointed out that we can avoid separately allocating struct
>> cake_sched_config even in the non-mq case, by embedding it into struct
>> cake_sched_data. This reduces the complexity of the logic that swaps the
>> pointers and frees the old value, at the cost of adding 56 bytes to the
>> latter. Since cake_sched_data is already almost 17k bytes, this seems
>> like a reasonable tradeoff.
>>
>> Suggested-by: Paolo Abeni <pabeni@...hat.com>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>> ---
>
> This is also fixing a panic, so :
>
> Fixes: bc0ce2bad36c ("net/sched: sch_cake: Factor out config variables
> into separate struct")
>
> For the record, a fix for the panic would be :

Ah yes, of course; thanks for noticing (and for the tag)!

-Toke