netdev - Re: [PATCH net] amd-xgbe: avoid misleading per-packet error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ab70f51-9dc6-444b-b3c1-c6f0a661ab69@amd.com>
Date: Wed, 14 Jan 2026 20:42:00 +0530
From: "Rangoju, Raju" <raju.rangoju@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Thomas.Lendacky@....com,
 Shyam-sundar.S-k@....com
Subject: Re: [PATCH net] amd-xgbe: avoid misleading per-packet error log



On 1/13/2026 8:58 AM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Sat, 10 Jan 2026 22:34:22 +0530 Raju Rangoju wrote:
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
>> index 0d19b09497a0..c8797a338542 100644
>> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
>> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
>> @@ -75,6 +75,8 @@ static const struct xgbe_stats xgbe_gstring_stats[] = {
>>        XGMAC_MMC_STAT("rx_pause_frames", rxpauseframes),
>>        XGMAC_EXT_STAT("rx_split_header_packets", rx_split_header_packets),
>>        XGMAC_EXT_STAT("rx_buffer_unavailable", rx_buffer_unavailable),
>> +     XGMAC_EXT_STAT("rx_buffer_overflow", rx_buffer_overflow),
> 
> "rx_buffer_overflow" sounds like something that should be categorized
> to one of the struct rtnl_link_stats64 stats. See the kdoc in if_link.h
> 
>> +     XGMAC_EXT_STAT("rx_pkt_errors", rx_pkt_errors),
> 
> Are these counted to standard rx_errors somewhere?

Yes, I believe this and the above stats are counted as part of standard 
rtnl_link_stats64. Thanks for reviewing this Jakub.

I'll respin v2 fixing these.

> --
> pw-bot: cr