netdev - RE: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
 <PAXPR07MB7984206EEC94880B5A7CC54AA38FA@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Wed, 14 Jan 2026 16:12:56 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, Neal Cardwell
	<ncardwell@...gle.com>
CC: "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "parav@...dia.com" <parav@...dia.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "corbet@....net"
	<corbet@....net>, "horms@...nel.org" <horms@...nel.org>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "kuniyu@...gle.com" <kuniyu@...gle.com>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "donald.hunter@...il.com"
	<donald.hunter@...il.com>, "ast@...erby.net" <ast@...erby.net>,
	"liuhangbin@...il.com" <liuhangbin@...il.com>, "shuah@...nel.org"
	<shuah@...nel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "ij@...nel.org" <ij@...nel.org>, "Koen De
 Schepper (Nokia)" <koen.de_schepper@...ia-bell-labs.com>,
	"g.white@...lelabs.com" <g.white@...lelabs.com>,
	"ingemar.s.johansson@...csson.com" <ingemar.s.johansson@...csson.com>,
	"mirja.kuehlewind@...csson.com" <mirja.kuehlewind@...csson.com>, cheshire
	<cheshire@...le.com>, "rs.ietf@....at" <rs.ietf@....at>,
	"Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>, Vidhi Goel
	<vidhi_goel@...le.com>, Willem de Bruijn <willemb@...gle.com>
Subject: RE: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill
 cases

> -----Original Message-----
> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Sent: Wednesday, January 14, 2026 3:18 PM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>; Neal Cardwell <ncardwell@...gle.com>
> Cc: pabeni@...hat.com; edumazet@...gle.com; parav@...dia.com; linux-doc@...r.kernel.org; corbet@....net; horms@...nel.org; dsahern@...nel.org; kuniyu@...gle.com; bpf@...r.kernel.org; netdev@...r.kernel.org; dave.taht@...il.com; jhs@...atatu.com; kuba@...nel.org; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; andrew+netdev@...n.ch; donald.hunter@...il.com; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire <cheshire@...le.com>; rs.ietf@....at; Jason_Livingood@...cast.com; Vidhi Goel <vidhi_goel@...le.com>; Willem de Bruijn <willemb@...gle.com>
> Subject: RE: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases
>
> [You don't often get email from willemdebruijn.kernel@...il.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
>
>
>
> Chia-Yu Chang (Nokia) wrote:
> > > -----Original Message-----
> > > From: Neal Cardwell <ncardwell@...gle.com>
> > > Sent: Thursday, January 8, 2026 11:47 PM
> > > To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
> > > Cc: pabeni@...hat.com; edumazet@...gle.com; parav@...dia.com;
> > > linux-doc@...r.kernel.org; corbet@....net; horms@...nel.org;
> > > dsahern@...nel.org; kuniyu@...gle.com; bpf@...r.kernel.org;
> > > netdev@...r.kernel.org; dave.taht@...il.com; jhs@...atatu.com;
> > > kuba@...nel.org; stephen@...workplumber.org;
> > > xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net;
> > > andrew+netdev@...n.ch; donald.hunter@...il.com; ast@...erby.net;
> > > liuhangbin@...il.com; shuah@...nel.org;
> > > linux-kselftest@...r.kernel.org; ij@...nel.org; Koen De Schepper
> > > (Nokia) <koen.de_schepper@...ia-bell-labs.com>;
> > > g.white@...lelabs.com; ingemar.s.johansson@...csson.com;
> > > mirja.kuehlewind@...csson.com; cheshire <cheshire@...le.com>;
> > > rs.ietf@....at; Jason_Livingood@...cast.com; Vidhi Goel
> > > <vidhi_goel@...le.com>; Willem de Bruijn <willemb@...gle.com>
> > > Subject: Re: [PATCH net-next 1/1] selftests/net: Add packetdrill
> > > packetdrill cases
> > >
> > >
> > > CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> > >
> > >
> > >
> > > On Thu, Jan 8, 2026 at 10:58 AM <chia-yu.chang@...ia-bell-labs.com> wrote:
> > > >
> > > > From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
> > > >
> > > > Linux Accurate ECN test sets using ACE counters and AccECN options
> > > > to cover several scenarios: Connection teardown, different ACK
> > > > conditions, counter wrapping, SACK space grabbing, fallback
> > > > schemes, negotiation retransmission/reorder/loss, AccECN option
> > > > drop/loss, different handshake reflectors, data with marking, and different sysctl values.
> > > >
> > > > Co-developed-by: Ilpo Järvinen <ij@...nel.org>
> > > > Signed-off-by: Ilpo Järvinen <ij@...nel.org>
> > > > Co-developed-by: Neal Cardwell <ncardwell@...gle.com>
> > > > Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> > > > ---
> > >
> > > Chia-Yu, thank you for posting the packetdrill tests.
> > >
> > > A couple thoughts:
> > >
> > > (1) These tests are using the experimental AccECN packetdrill support that is not in mainline packetdrill yet. Can you please share the github URL for the version of packetdrill you used? I will work on merging the appropriate experimental AccECN packetdrill support into the Google packetdrill mainline branch.
> > >
> > > (2) The last I heard, the tools/testing/selftests/net/packetdrill/
> > > infrastructure does not run tests in subdirectories of that packetdrill/ directory, and that is why all the tests in tools/testing/selftests/net/packetdrill/ are in a single directory.
> > > When you run these tests, do all the tests actually get run? Just
> > > wanted to check this. :-)
> > >
> > > Thanks!
> > > neal
> >
> > Hi Neal,
> >
> > Regards (2), I will put all ACCECN cases in the
> > tools/testing/selftests/net/packetdrill/
> > But I would like to include another script to avoid running these AccECN tests one-by-one manually, does it make sense to you?
> > Thanks.
>
> All scripts under tools/testing/selftests/net/packetdrill are already picked up for automated testing in kselftests:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=8a405552fd3b

OK, I was using ksft_runner.sh to run all 58 AccECN case one-by-one.

But since run_kselftest.sh can accept multiple "-t" arguments, so I will not commit another script with similar functionlaities but just rename all AccECN case with tcp_accecn in the prefix.

Thanks.

Chia-Yu