netdev - Re: [PATCH net-next] tcp: move tcp_rate_skb_sent() to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQy=_oWWBwFBmn9pPn_VK5qJ-y5uVSwXn01XJJYCOJP=3gw@mail.gmail.com>
Date: Wed, 14 Jan 2026 12:15:22 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: move tcp_rate_skb_sent() to tcp_output.c

On Wed, Jan 14, 2026 at 11:51 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> It is only called from __tcp_transmit_skb() and __tcp_retransmit_skb().
>
> Move it in tcp_output.c and make it static.
>
> clang compiler is now able to inline it from __tcp_transmit_skb().
>
> gcc compiler inlines it in the two callers, which is also fine.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

Thanks, Eric!

neal