netdev - Re: [PATCH v2][next] virtio_net: Fix misalignment bug in struct virtnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260113181658.0b65b96e@kernel.org>
Date: Tue, 13 Jan 2026 18:16:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, "Gustavo A. R. Silva"
 <gustavoars@...nel.org>, Jason Wang <jasowang@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Akihiko
 Odaki <akihiko.odaki@...nix.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Kees Cook
 <kees@...nel.org>
Subject: Re: [PATCH v2][next] virtio_net: Fix misalignment bug in struct
 virtnet_info

On Tue, 13 Jan 2026 16:06:05 +0100 Paolo Abeni wrote:
> > Probably but I'm yet to properly review it. The thing that puzzles me at
> > a first glance is how are things working right now then?  
> 
> Apparently they aren't ?!?
> 
> rss self-tests for virtio_net are failing:
> 
> https://netdev-ctrl.bots.linux.dev/logs/vmksft/drv-hw-dbg/results/471521/15-rss-api-py/stdout
> 
> but the result is into the CI reported as success (no idea why?!?)

To be clear this is a HW test so the fact that it shows up in CI as
green means just that the 2 sub cases (per [1]) which the CI judged 
to be stable and passing are still passing. The other 10 sub cases 
have never passed and still don't. IDK if you QEMU doesn't support 
RSS or it's something else but AFAICT this patch doesn't appear to 
make a difference to us.

[1] https://netdev.bots.linux.dev/devices.html

You can see the per-case breakdown of the history here (including 
the ignored sub-cases):
https://netdev.bots.linux.dev/flakes.html?tn-needle=drv-hw%2Fselftests-drivers-net-hw%2Frss-api-py&min-flip=0&br-pfx=net-next-hw&ld-cases=1