netdev - Re: [PATCH RFC net-next v3 2/4] net: dsa: add tag formats for MxL862xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260114230608.qoojzz332jubiaqg@skbuf>
Date: Thu, 15 Jan 2026 01:06:08 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Frank Wunderlich <frankwu@....de>, Chad Monroe <chad@...roe.io>,
	Cezary Wilmanski <cezary.wilmanski@...ran.com>,
	Avinash Jayaraman <ajayaraman@...linear.com>,
	Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
	Juraj Povazanec <jpovazanec@...linear.com>,
	"Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
	"Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
	"Livia M. Rosu" <lrosu@...linear.com>,
	John Crispin <john@...ozen.org>
Subject: Re: [PATCH RFC net-next v3 2/4] net: dsa: add tag formats for
 MxL862xx switches

On Tue, Jan 06, 2026 at 02:57:56AM +0000, Daniel Golle wrote:
> On Tue, Dec 16, 2025 at 10:39:35PM +0200, Vladimir Oltean wrote:
> > On Mon, Dec 15, 2025 at 12:11:43AM +0000, Daniel Golle wrote:
> > > the actual tag format differs significantly, hence we need a dedicated
> > > tag driver for that.
> > 
> > Reusing the same EtherType for two different DSA tagging protocols is
> > very bad news, possibly with implications also for libpcap. Is the
> > EtherType configurable in the MXL862xx family?
> 
> Only the egress EtherType can be configured, there is currently no way
> to configure the ingress EtherType the switch expects to receive on
> special-tag packets on the CPU port. MaxLinear, however, said they could
> in theory release a new firmware changing the EtherType to any suggested
> value, but it would be incompatible with existing downstream drivers in
> the field, obviously.

Sorry for the late response.

I don't think it is a deal breaker. For all I know so far, we can
probably live with the same EtherType being used for multiple protocols,
and the distinction is made by the /sys/class/net/eth0/dsa/tagging string.