netdev - Re: [PATCH] rxrpc: Fix data-race warning and potential load/store tearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202601141152.2TfkKMKv-lkp@intel.com>
Date: Wed, 14 Jan 2026 11:31:58 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>, netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	dhowells@...hat.com,
	syzbot+6182afad5045e6703b3d@...kaller.appspotmail.com,
	Marc Dionne <marc.dionne@...istor.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, linux-afs@...ts.infradead.org,
	stable@...nel.org, linux-kernel@...nel.org
Subject: Re: [PATCH] rxrpc: Fix data-race warning and potential load/store
 tearing

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.19-rc5 next-20260113]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Howells/rxrpc-Fix-data-race-warning-and-potential-load-store-tearing/20260114-005726
base:   net/main
patch link:    https://lore.kernel.org/r/3535584.1768322992%40warthog.procyon.org.uk
patch subject: [PATCH] rxrpc: Fix data-race warning and potential load/store tearing
config: x86_64-buildonly-randconfig-006-20260114 (https://download.01.org/0day-ci/archive/20260114/202601141152.2TfkKMKv-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260114/202601141152.2TfkKMKv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601141152.2TfkKMKv-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/rxrpc/proc.c:305:6: warning: format specifies type 'unsigned long long' but the argument has type 's32' (aka 'int') [-Wformat]
     299 |                    "UDP   %-47.47s %-47.47s %3u %4u %5u %6llus %8d %8d\n",
         |                                                         ~~~~~
         |                                                         %6d
     300 |                    lbuff,
     301 |                    rbuff,
     302 |                    refcount_read(&peer->ref),
     303 |                    peer->cong_ssthresh,
     304 |                    peer->max_data,
     305 |                    (s32)now - (s32)peer->last_tx_at,
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +305 net/rxrpc/proc.c

   274	
   275	/*
   276	 * generate a list of extant virtual peers in /proc/net/rxrpc/peers
   277	 */
   278	static int rxrpc_peer_seq_show(struct seq_file *seq, void *v)
   279	{
   280		struct rxrpc_peer *peer;
   281		time64_t now;
   282		char lbuff[50], rbuff[50];
   283	
   284		if (v == SEQ_START_TOKEN) {
   285			seq_puts(seq,
   286				 "Proto Local                                           Remote                                          Use SST   Maxd LastUse      RTT      RTO\n"
   287				 );
   288			return 0;
   289		}
   290	
   291		peer = list_entry(v, struct rxrpc_peer, hash_link);
   292	
   293		sprintf(lbuff, "%pISpc", &peer->local->srx.transport);
   294	
   295		sprintf(rbuff, "%pISpc", &peer->srx.transport);
   296	
   297		now = ktime_get_seconds();
   298		seq_printf(seq,
   299			   "UDP   %-47.47s %-47.47s %3u %4u %5u %6llus %8d %8d\n",
   300			   lbuff,
   301			   rbuff,
   302			   refcount_read(&peer->ref),
   303			   peer->cong_ssthresh,
   304			   peer->max_data,
 > 305			   (s32)now - (s32)peer->last_tx_at,
   306			   READ_ONCE(peer->recent_srtt_us),
   307			   READ_ONCE(peer->recent_rto_us));
   308	
   309		return 0;
   310	}
   311	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki