netdev - Re: [net-next,V0.5,5/5] eth: fbnic: Update RX mbox timeout value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260114033824.1033374-1-kuba@kernel.org>
Date: Tue, 13 Jan 2026 19:38:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: mohsin.bashr@...il.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	netdev@...r.kernel.org,
	jacob.e.keller@...el.com,
	davem@...emloft.net,
	sanman.p211993@...il.com,
	pabeni@...hat.com,
	andrew+netdev@...n.ch,
	horms@...nel.org,
	alexanderduyck@...com,
	kernel-team@...a.com,
	edumazet@...gle.com,
	lee@...ger.us
Subject: Re: [net-next,V0.5,5/5] eth: fbnic: Update RX mbox timeout value

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least pausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
eth: fbnic: Update RX mbox timeout value

This commit unifies timeout values for mailbox RX read requests and
introduces a wrapper function fbnic_mbx_wait_for_cmpl() to simplify the
completion wait calls.

> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.h b/drivers/net/ethernet/meta/fbnic/fbnic_fw.h
> index 1ecd777aaada..6b3fb163d381 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.h
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.h

[ ... ]

> +static inline bool fbnic_mbx_wait_for_cmpl(struct fbnic_fw_completion *cmpl)
> +{
> +	return wait_for_completion_timeout(&cmpl->done,
> +					   FBNIC_MBX_RX_TO_SEC * HZ);
> +}

The wrapper returns the result of wait_for_completion_timeout() which is
non-zero (remaining jiffies) on success and zero on timeout.

> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> index b62b1d5b1453..193f554717b3 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> @@ -178,7 +178,7 @@ fbnic_flash_start(struct fbnic_dev *fbd, struct pldmfw_component *component)
>  		goto cmpl_free;
>
>  	/* Wait for firmware to ack firmware upgrade start */
> -	if (wait_for_completion_timeout(&cmpl->done, 10 * HZ))
> +	if (!fbnic_mbx_wait_for_cmpl(cmpl))
>  		err = cmpl->result;
>  	else
>  		err = -ETIMEDOUT;

Is the condition inverted here? The original code enters the first branch
when wait_for_completion_timeout() returns non-zero (success). The new
code enters the first branch when fbnic_mbx_wait_for_cmpl() returns zero
(timeout) due to the added negation. This would cause successful
completions to return -ETIMEDOUT.

[ ... ]

> @@ -447,7 +447,7 @@ static int fbnic_fw_reporter_dump(struct devlink_health_reporter *reporter,
>  				goto cmpl_cleanup;
>  		}
>
> -		if (wait_for_completion_timeout(&fw_cmpl->done, 2 * HZ)) {
> +		if (!fbnic_mbx_wait_for_cmpl(fw_cmpl)) {
>  			reinit_completion(&fw_cmpl->done);
>  		} else {
>  			NL_SET_ERR_MSG_FMT_MOD(extack,

Similar issue in this loop - the original code calls reinit_completion()
on success (non-zero return) and goes to error handling on timeout (zero
return). With the added negation, success now triggers the error path
setting err = -ETIMEDOUT, while timeout triggers reinit_completion().