netdev - Re: [PATCH v3 net-next 10/10] selftests: net: tests for add double tunneling GRO/GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871pjr6t08.fsf@nvidia.com>
Date: Thu, 15 Jan 2026 11:13:30 +0100
From: Petr Machata <petrm@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Simon
 Horman" <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>, "Andrew
 Lunn" <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>, "Willem de
 Bruijn" <willemdebruijn.kernel@...il.com>, <sdf@...ichev.me>,
	<petrm@...dia.com>, <razor@...ckwall.org>, <idosch@...dia.com>
Subject: Re: [PATCH v3 net-next 10/10] selftests: net: tests for add double
 tunneling GRO/GSO


Paolo Abeni <pabeni@...hat.com> writes:

> Create a simple, netns-based topology with double, nested UDP tunnels and
> perform TSO transfers on top.
>
> Explicitly enable GSO and/or GRO and check the skb layout consistency with
> different configuration allowing (or not) GSO frames to be delivered on
> the other end.
>
> The trickest part is account in a robust way the aggregated/unaggregated
> packets with double encapsulation: use a classic bpf filter for it.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Looks OK overall, just:

> diff --git a/tools/testing/selftests/net/double_udp_encap.sh b/tools/testing/selftests/net/double_udp_encap.sh
> new file mode 100755
> index 000000000000..055f65b4d18d
> --- /dev/null
> +++ b/tools/testing/selftests/net/double_udp_encap.sh

> +# tcp retransmisions will break the accounting
> +[ "$KSFT_MACHINE_SLOW" = yes ] && FAIL_TO_XFAIL=yes

You should just be able to call `xfail_on_slow' without an argument to
apply the setting globally.

Selftests shouldn't have to touch FAIL_TO_XFAIL directly.