netdev - Re: [PATCH net-next v8 7/9] eth: bnxt: support qcfg provided rx page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c0f28de-41dd-47c6-9b0b-9ea40cbbeab2@gmail.com>
Date: Thu, 15 Jan 2026 17:10:55 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Jonathan Corbet <corbet@....net>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Joshua Washington <joshwash@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Saeed Mahameed <saeedm@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
 Mark Bloch <mbloch@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Alexander Duyck <alexanderduyck@...com>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>, Shuah Khan
 <shuah@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 Ankit Garg <nktgrg@...gle.com>, Tim Hostetler <thostet@...gle.com>,
 Alok Tiwari <alok.a.tiwari@...cle.com>, Ziwei Xiao <ziweixiao@...gle.com>,
 John Fraker <jfraker@...gle.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Mohsin Bashir <mohsin.bashr@...il.com>, Joe Damato <joe@...a.to>,
 Mina Almasry <almasrymina@...gle.com>,
 Dimitri Daskalakis <dimitri.daskalakis1@...il.com>,
 Stanislav Fomichev <sdf@...ichev.me>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 Samiullah Khawaja <skhawaja@...gle.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>, David Wei
 <dw@...idwei.uk>, Yue Haibing <yuehaibing@...wei.com>,
 Haiyue Wang <haiyuewa@....com>, Jens Axboe <axboe@...nel.dk>,
 Simon Horman <horms@...nel.org>, Vishwanath Seshagiri <vishs@...com>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kselftest@...r.kernel.org, dtatulea@...dia.com,
 io-uring@...r.kernel.org
Subject: Re: [PATCH net-next v8 7/9] eth: bnxt: support qcfg provided rx page
 size

On 1/14/26 03:36, Jakub Kicinski wrote:
> On Fri,  9 Jan 2026 11:28:46 +0000 Pavel Begunkov wrote:
>> @@ -4342,7 +4343,8 @@ static void bnxt_init_ring_struct(struct bnxt *bp)
>>   		if (!rxr)
>>   			goto skip_rx;
>>   
>> -		rxr->rx_page_size = BNXT_RX_PAGE_SIZE;
>> +		rxq = __netif_get_rx_queue(bp->dev, i);
>> +		rxr->rx_page_size = rxq->qcfg.rx_page_size;
> 
> Pretty sure I asked for the netdev_queue_config() helper to make
> a return, instead of drivers poking directly into core state.
> Having the config live in rxq directly is also ugh.

Having a helper would be a good idea, but I went for stashing
configs in the queue as it's simpler, while dynamic allocations
were of no benefit for this series. Maybe there are some further
plans for it, but as you mentioned, it'd be better to do on top.

> But at this stage we're probably better off if you just respin
> to fix the nits from Paolo and I try to de-lobotimize the driver
> facing API. This is close enough.

Ok

-- 
Pavel Begunkov