netdev - Re: [PATCH v1 net 2/2] fou: Don't allow 0 for FOU_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUAafpy7QC4bAff9Yx0utaoGkCf-L79Tc9C7bcqDrzO3ew@mail.gmail.com>
Date: Wed, 14 Jan 2026 23:43:36 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Tom Herbert <therbert@...gle.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net 2/2] fou: Don't allow 0 for FOU_ATTR_IPPROTO.

On Wed, Jan 14, 2026 at 7:40 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 13 Jan 2026 23:15:42 -0800 Kuniyuki Iwashima wrote:
> > Btw I needed the change below to generate the diff above
> > by "./tools/net/ynl/ynl-regen.sh -f".  Maybe depending on
> >
> >
> > diff --git a/tools/net/ynl/ynl-regen.sh b/tools/net/ynl/ynl-regen.sh
> > index 81b4ecd891006..fda5fe24cfd47 100755
> > --- a/tools/net/ynl/ynl-regen.sh
> > +++ b/tools/net/ynl/ynl-regen.sh
> > @@ -29,9 +29,9 @@ for f in $files; do
> >   continue
> >      fi
> >
> > -    echo -e "\tGEN ${params[2]}\t$f"
> > -    $TOOL --cmp-out --mode ${params[2]} --${params[3]} \
> > -   --spec $KDIR/${params[0]} $args -o $f
> > +    echo -e "\tGEN ${params[5]}\t$f"
> > +    $TOOL --cmp-out --mode ${params[4]} --${params[5]} \
> > +   --spec $KDIR/${params[1]} $args -o $f
> >  done
> >
> >  popd >>/dev/null
> >
> >
> > fwiw, $params were like
> >
> > 3- Documentation/netlink/specs/fou.yaml
> > 4: YNL-GEN kernel source
> > --
> > 3- Documentation/netlink/specs/fou.yaml
> > 4: YNL-GEN kernel header
>
> Hm, I guess you have grep.lineNumber enabled in your git config?

Ah exactly, I didn't know that my corp machine enabled
it globally by default :)


> Could you see if tossing --no-line-number into the git grep
> in this script fixes it for you and if yes send a patch?

It worked, I'll include it in the series.

Thank you!