netdev - Re: [PATCH net-next] selftests: tls: use mkstemp instead of open(O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <748dbd7653d31edaccb54425788bbf9a6881da89.camel@kernel.org>
Date: Thu, 15 Jan 2026 17:08:46 +0800
From: Geliang Tang <geliang@...nel.org>
To: John Fastabend <john.fastabend@...il.com>, Jakub Kicinski
 <kuba@...nel.org>,  Sabrina Dubroca <sd@...asysnail.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,  Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan
 <shuah@...nel.org>
Cc: Gang Yan <yangang@...inos.cn>, netdev@...r.kernel.org, 
	mptcp@...ts.linux.dev
Subject: Re: [PATCH net-next] selftests: tls: use mkstemp instead of
 open(O_TMPFILE)

On Wed, 2026-01-14 at 10:12 +0800, Geliang Tang wrote:
> From: Gang Yan <yangang@...inos.cn>
> 
> When running TLS tests in a virtual machine/container environment,
> they
> fail:
> 
>  # tls.c:1479:mutliproc_even: Expected fd (-1) >= 0 (0)
>  # mutliproc_even: Test terminated by assertion
>  #          FAIL  tls.12_aes_gcm.mutliproc_even
>  not ok 59 tls.12_aes_gcm.mutliproc_even
>  #  RUN           tls.12_aes_gcm.mutliproc_readers ...
>  # tls.c:1479:mutliproc_readers: Expected fd (-1) >= 0 (0)
>  # mutliproc_readers: Test terminated by assertion
>  #          FAIL  tls.12_aes_gcm.mutliproc_readers
>  not ok 60 tls.12_aes_gcm.mutliproc_readers
>  #  RUN           tls.12_aes_gcm.mutliproc_writers ...
>  # tls.c:1479:mutliproc_writers: Expected fd (-1) >= 0 (0)
>  # mutliproc_writers: Test terminated by assertion
>  #          FAIL  tls.12_aes_gcm.mutliproc_writers
>  not ok 61 tls.12_aes_gcm.mutliproc_writers
> 
> This is because the /tmp directory uses the virtiofs filesystem,
> which does
> not support the O_TMPFILE feature.
> 
> This patch uses mkstemp() to create temporary files, thereby
> eliminating
> the dependency on the O_TMPFILE feature. And closes the file
> descriptor
> (fd) and deletes the temfile after the test ends.
> 
> Co-developed-by: Geliang Tang <geliang@...nel.org>
> Signed-off-by: Geliang Tang <geliang@...nel.org>
> Signed-off-by: Gang Yan <yangang@...inos.cn>
> ---
>  tools/testing/selftests/net/tls.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/tls.c
> b/tools/testing/selftests/net/tls.c
> index 9e2ccea13d70..f4b8dd99d501 100644
> --- a/tools/testing/selftests/net/tls.c
> +++ b/tools/testing/selftests/net/tls.c
> @@ -1456,6 +1456,7 @@ test_mutliproc(struct __test_metadata
> *_metadata, struct _test_data_tls *self,
>  	       bool sendpg, unsigned int n_readers, unsigned int
> n_writers)
>  {
>  	const unsigned int n_children = n_readers + n_writers;
> +	char tmpfile[] = "/tmp/tls_test_tmpfile_XXXXXX";
>  	const size_t data = 6 * 1000 * 1000;
>  	const size_t file_sz = data / 100;
>  	size_t read_bias, write_bias;
> @@ -1469,7 +1470,7 @@ test_mutliproc(struct __test_metadata
> *_metadata, struct _test_data_tls *self,
>  	write_bias = n_readers / n_writers ?: 1;
>  
>  	/* prep a file to send */
> -	fd = open("/tmp/", O_TMPFILE | O_RDWR, 0600);
> +	fd = mkstemp(tmpfile);

Superseded.

I noticed that this mkstemp approach was already implemented in
chunked_sendfile(). To eliminate duplication, in v2 I just submitted, I
extracted this logic into a new helper create_temp_file(), which is now
shared by both chunked_sendfile() and test_mutliproc().

Thanks,
-Geliang

>  	ASSERT_GE(fd, 0);
>  
>  	memset(buf, 0xac, file_sz);
> @@ -1527,6 +1528,8 @@ test_mutliproc(struct __test_metadata
> *_metadata, struct _test_data_tls *self,
>  			left -= res;
>  		}
>  	}
> +	close(fd);
> +	unlink(tmpfile);
>  }
>  
>  TEST_F(tls, mutliproc_even)