netdev - Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260115091439.2216-1-always.starving0@gmail.com>
Date: Thu, 15 Jan 2026 01:11:23 -0800
From: Jinseok Kim <always.starving0@...il.com>
To: kuba@...nel.org
Cc: always.starving0@...il.com,
	andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	quic_luoj@...cinc.com
Subject: Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h

Thanks for the review!

I suggested removing the direct #include <linux/dev_printk.h> because
this is the only file under net/ethernet/qualcomm/ that explicitly includes it.
All other files use dev_err() etc. just fine via <linux/device.h>.

But you're right — relying on indirect includes isn't ideal...
I'll leave it as-is for now.