netdev - Re: [PATCH v2 net-next 10/14] net: fec: remove the size parameter from fec_enet_create_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWpKqT/bJE8i9gDY@lizhi-Precision-Tower-5810>
Date: Fri, 16 Jan 2026 09:26:49 -0500
From: Frank Li <Frank.li@....com>
To: Wei Fang <wei.fang@....com>
Cc: shenwei.wang@....com, xiaoning.wang@....com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
	hawk@...nel.org, john.fastabend@...il.com, sdf@...ichev.me,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH v2 net-next 10/14] net: fec: remove the size parameter
 from fec_enet_create_page_pool()

On Fri, Jan 16, 2026 at 03:40:23PM +0800, Wei Fang wrote:
> Since the rxq is one of the parameters of fec_enet_create_page_pool(),
> so we can get the ring size from rxq->bd.ring_size, so it is safe to
> remove the size parameter from fec_enet_create_page_pool().

Remove the size parameter from fec_enet_create_page_pool(), since
rxq->bd.ring_size already contains this information.

Reviewed-by: Frank Li <Frank.Li@....com>
>
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 2f79ef195a9e..c1786ccf0443 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -467,13 +467,13 @@ fec_enet_clear_csum(struct sk_buff *skb, struct net_device *ndev)
>
>  static int
>  fec_enet_create_page_pool(struct fec_enet_private *fep,
> -			  struct fec_enet_priv_rx_q *rxq, int size)
> +			  struct fec_enet_priv_rx_q *rxq)
>  {
>  	struct bpf_prog *xdp_prog = READ_ONCE(fep->xdp_prog);
>  	struct page_pool_params pp_params = {
>  		.order = fep->pagepool_order,
>  		.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,
> -		.pool_size = size,
> +		.pool_size = rxq->bd.ring_size,
>  		.nid = dev_to_node(&fep->pdev->dev),
>  		.dev = &fep->pdev->dev,
>  		.dma_dir = xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE,
> @@ -3552,7 +3552,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
>  	rxq = fep->rx_queue[queue];
>  	bdp = rxq->bd.base;
>
> -	err = fec_enet_create_page_pool(fep, rxq, rxq->bd.ring_size);
> +	err = fec_enet_create_page_pool(fep, rxq);
>  	if (err < 0) {
>  		netdev_err(ndev, "%s failed queue %d (%d)\n", __func__, queue, err);
>  		return err;
> --
> 2.34.1
>