netdev - Re: [PATCH net] selftests: net: amt: wait longer for connection before sending packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+Zd2W_u665D=MExotaHtnnyqu8Z+LgfbDy2trmtqcAkw@mail.gmail.com>
Date: Sun, 18 Jan 2026 16:38:42 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	shuah@...nel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: amt: wait longer for connection
 before sending packets

On Sun, Jan 18, 2026 at 4:15 PM Taehee Yoo <ap420073@...il.com> wrote:
>
> There is a sleep 2 in send_mcast4() to wait for the connection to be
> established between the gateway and the relay.
>
> However, some tests fail because packets are sometimes sent before the
> connection is fully established.
>
> So, increase the waiting time to make the tests more reliable.
>
> Fixes: c08e8baea78e ("selftests: add amt interface selftest script")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> ---
>  tools/testing/selftests/net/amt.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/amt.sh b/tools/testing/selftests/net/amt.sh
> index 3ef209cacb8e..fe2497d9caff 100755
> --- a/tools/testing/selftests/net/amt.sh
> +++ b/tools/testing/selftests/net/amt.sh
> @@ -246,7 +246,7 @@ test_ipv6_forward()
>
>  send_mcast4()
>  {
> -       sleep 2
> +       sleep 5

1) Have you considered using wait_local_port_listen instead ?

2) What about send_mcast6() ?

>         ip netns exec "${SOURCE}" bash -c \
>                 'printf "%s %128s" 172.17.0.2 | nc -w 1 -u 239.0.0.1 4000' &
>  }
> --
> 2.43.0
>