netdev - Re: [net-next] net: phy: intel-xway: workaround stale LEDs before link-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWxGkAUlvyleFC1A@makrotopia.org>
Date: Sun, 18 Jan 2026 02:33:52 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: fchan@...linear.com, hkallweit1@...il.com, jpovazanec@...linear.com,
	yweng@...linear.com, davem@...emloft.net, andrew@...n.ch,
	linux@...linux.org.uk, edumazet@...gle.com,
	ajayaraman@...linear.com, john@...ozen.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	lrosu@...linear.com, bxu@...linear.com, pabeni@...hat.com
Subject: Re: [net-next] net: phy: intel-xway: workaround stale LEDs before
 link-up

On Sat, Jan 17, 2026 at 06:31:45PM -0800, Jakub Kicinski wrote:
> On Sat, 17 Jan 2026 18:29:07 -0800 Jakub Kicinski wrote:
> > > @@ -286,8 +287,33 @@ static int xway_gphy_config_init(struct phy_device *phydev)
> > >  		return err;
> > >
> > >  	/* Use default LED configuration if 'leds' node isn't defined */
> > > -	if (!of_get_child_by_name(np, "leds"))
> > > +	if (!of_get_child_by_name(np, "leds")) {
> > >  		xway_gphy_init_leds(phydev);
> > > +	} else {  
> > 
> > Does this leak the device_node reference returned by of_get_child_by_name()?
> 
> Of course this is a pre-existing issue but could you fix it first
> in net then proceed with this submission? Otherwise we'll have a
> conflict.

Ack. I'll send the fix for this to net first, then resend this patch
after the merge of net-next and net.