netdev - Re: [net,v2] rxrpc: Fix data-race warning and potential load/store tearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <916127.1768737781@warthog.procyon.org.uk>
Date: Sun, 18 Jan 2026 12:03:01 +0000
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dhowells@...hat.com, netdev@...r.kernel.org
Subject: Re: [net,v2] rxrpc: Fix data-race warning and potential load/store tearing

Jakub Kicinski <kuba@...nel.org> wrote:

> > +		   (s32)now - (s32)peer->last_tx_at,
>                                  ^^^^^^^^^^^^^^^^^
> 
> Should this read use READ_ONCE(peer->last_tx_at) for consistency with the
> data-race fix?  The new rxrpc_peer_get_tx_mark() uses READ_ONCE for the
> same field, and the same seq_printf uses READ_ONCE for recent_srtt_us and
> recent_rto_us on the following lines.

I suppose.  Racing doesn't matter here as it's just displaying the value;
tearing might matter, but it's now a 32-bit field.

David