netdev - Re: [PATCH net-next 1/8] net: core: neighbour: Add a neigh_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a4y9iyb4.fsf@nvidia.com>
Date: Mon, 19 Jan 2026 13:25:36 +0100
From: Petr Machata <petrm@...dia.com>
To: Petr Machata <petrm@...dia.com>
CC: Kuniyuki Iwashima <kuniyu@...gle.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, <netdev@...r.kernel.org>, Ido Schimmel
	<idosch@...dia.com>, Breno Leitao <leitao@...ian.org>, Andy Roulin
	<aroulin@...dia.com>, Francesco Ruggeri <fruggeri@...sta.com>, "Stephen
 Hemminger" <stephen@...workplumber.org>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 1/8] net: core: neighbour: Add a
 neigh_fill_info() helper for when lock not held


Petr Machata <petrm@...dia.com> writes:

> Kuniyuki Iwashima <kuniyu@...gle.com> writes:
>
>> On Wed, Jan 14, 2026 at 1:56 AM Petr Machata <petrm@...dia.com> wrote:
>>
>>> @@ -2684,6 +2680,20 @@ static int neigh_fill_info(struct sk_buff *skb, struct neighbour *neigh,
>>>         return -EMSGSIZE;
>>>  }
>>>
>>> +static int neigh_fill_info(struct sk_buff *skb, struct neighbour *neigh,
>>> +                          u32 pid, u32 seq, int type, unsigned int flags)
>>> +       __releases(neigh->lock)
>>> +       __acquires(neigh->lock)
>>
>> nit: Does Sparse complain without these annotations even
>> a function has a paired lock/unlock ops ?
>
> Actually it doesn't. Should I respin for this?

I'll be respinning anyway, so I'll include this as well.