netdev - Re: [PATCH iwl-next v1 6/7] ixgbe: replace EEE enable flag with state enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4263db7a-fe7d-4bd7-a33b-54fd0a8d570d@lunn.ch>
Date: Mon, 19 Jan 2026 15:26:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH iwl-next v1 6/7] ixgbe: replace EEE enable flag with
 state enum

> i've checked the scenario and, indeed, EEE gets reenabled once link
> conditions are meet again even without driver intervention.
> Thanks for pointing me that.
> In that case i will remove link enablement/disablement on driver side,
> but i am wondering whether leaving logging trace on link condition
> change (EEE gets disabled due to unsupported link conditions) would be
> beneficial
> WDUT?
> then keeping tristate EEE would be required i believe

The current phylib/phylink code does not log this. There is also not
much the user can do about it, if EEE is disabled, other than throw
the ixgbe out and get a card which does implement EEE at lower speeds.

    Andrew