netdev - RE: [PATCH iwl-next 1/2] ixgbe: e610: add missing endianness conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR11MB59835C040A04AEE704410E94F388A@PH7PR11MB5983.namprd11.prod.outlook.com>
Date: Mon, 19 Jan 2026 16:07:21 +0000
From: "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "horms@...nel.org"
	<horms@...nel.org>, "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: RE: [PATCH iwl-next 1/2] ixgbe: e610: add missing endianness
 conversion

>-----Original Message-----
>From: Dan Carpenter <dan.carpenter@...aro.org> 
>Sent: Sunday, January 18, 2026 1:57 PM
>To: Kwapulinski, Piotr <piotr.kwapulinski@...el.com>
>Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; horms@...nel.org; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
>Subject: Re: [PATCH iwl-next 1/2] ixgbe: e610: add missing endianness conversion
>
>On Fri, Jan 16, 2026 at 01:23:53PM +0100, Piotr Kwapulinski wrote:
>> Fix a possible ACI issue on big-endian platforms.
>> 
>> Fixes: 46761fd52a88 ("ixgbe: Add support for E610 FW Admin Command 
>> Interface")
>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
>> ---
>
>Intel has a lot of code which assume that it will only run on little endian systems...  Which is probably a fair assumption, honestly.
>For example:
>drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c:90 store_attr() warn: passing casted pointer '&input' to 'kstrtobool()' 32 vs 1.
>drivers/net/ethernet/intel/i40e/i40e_common.c:4345 i40e_led_get_reg() warn: passing casted pointer 'reg_val' to 'i40e_read_phy_register_clause45()' 32 vs 16.
>I seem them on occasion when I'm reviewing static checker warnings but I ignore them because Intel chips are little endian.
>
>I don't have a problem with fixing Sparse endianness warnings, but the commit message should really say that it doesn't affect real life.
Will update. Thank you.
Piotr
[...]