netdev - Re: [PATCH net-next] tcp: move tcp_rate_skb_delivered() to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQy=hRTstSpOVY5UxxBTdOmdDsqBQcYnFWCc8ikaqDSuvSg@mail.gmail.com>
Date: Mon, 19 Jan 2026 11:50:58 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: move tcp_rate_skb_delivered() to tcp_input.c

On Sun, Jan 18, 2026 at 7:32 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> tcp_rate_skb_delivered() is only called from tcp_input.c.
> Move it there and make it static.
>
> Both gcc and clang are (auto)inlining it, TCP performance
> is increased at a small space cost.
>
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 0/2 grow/shrink: 3/0 up/down: 509/-187 (322)
> Function                                     old     new   delta
> tcp_sacktag_walk                            1682    1867    +185
> tcp_ack                                     5230    5405    +175
> tcp_shifted_skb                              437     586    +149
> __pfx_tcp_rate_skb_delivered                  16       -     -16
> tcp_rate_skb_delivered                       171       -    -171
> Total: Before=22566192, After=22566514, chg +0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

Thanks, Eric!

neal