netdev - Re: [PATCH net-next v2 1/4] net: dsa: ks8995: Add shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLkcB12YT+bLe6G0OvC3zrc=sKJYVAYR-m=6-bv+c_+8Hw@mail.gmail.com>
Date: Mon, 19 Jan 2026 21:26:36 +0100
From: Linus Walleij <linusw@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Woojung Huh <woojung.huh@...rochip.com>, 
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/4] net: dsa: ks8995: Add shutdown callback

On Mon, Jan 19, 2026 at 5:33 PM Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 19 Jan 2026 17:38:50 +0200 Vladimir Oltean wrote:
> > On Mon, Jan 19, 2026 at 03:30:05PM +0100, Linus Walleij wrote:
> > > The DSA framework requires that dsa_switch_shutdown() be
> > > called when the driver is shut down.
> > >
> > > Fixes: a7fe8b266f65 ("net: dsa: ks8995: Add basic switch set-up")
> >
> > $ git tag --contains a7fe8b266f65
> > v6.18
> >
> > We are in the RC stage for v6.19, so this is 'net' material, not
> > 'net-next', the patch has already made it into a released kernel.
>
> The AI code review points out that the DSA docs/you suggest mutual
> exclusion with .remove. Do we also want this to be addressed?

That's pretty impressive. I need to learn how to
use this approach for my subsystems.

(Also fixing my patches.)

Yours,
Linus Walleij