netdev - Re: [PATCH net-next v7 03/16] net: Add lease info to queue-get response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW2Mec4NWre1axmO@mini-arch>
Date: Sun, 18 Jan 2026 17:44:25 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, kuba@...nel.org,
	davem@...emloft.net, razor@...ckwall.org, pabeni@...hat.com,
	willemb@...gle.com, sdf@...ichev.me, john.fastabend@...il.com,
	martin.lau@...nel.org, jordan@...fe.io,
	maciej.fijalkowski@...el.com, magnus.karlsson@...el.com,
	dw@...idwei.uk, toke@...hat.com, yangzhenze@...edance.com,
	wangdongdong.6@...edance.com
Subject: Re: [PATCH net-next v7 03/16] net: Add lease info to queue-get
 response

On 01/15, Daniel Borkmann wrote:
> Populate nested lease info to the queue-get response that returns the
> ifindex, queue id with type and optionally netns id if the device
> resides in a different netns.
> 
> Example with ynl client:
> 
>   # ip a
>   [...]
>   4: enp10s0f0np0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdp/id:24 qdisc mq state UP group default qlen 1000
>     link/ether e8:eb:d3:a3:43:f6 brd ff:ff:ff:ff:ff:ff
>     inet 10.0.0.2/24 scope global enp10s0f0np0
>        valid_lft forever preferred_lft forever
>     inet6 fe80::eaeb:d3ff:fea3:43f6/64 scope link proto kernel_ll
>        valid_lft forever preferred_lft forever
>   [...]
> 
>   # ethtool -i enp10s0f0np0
>   driver: mlx5_core
>   [...]
> 
>   # ./pyynl/cli.py \
>       --spec ~/netlink/specs/netdev.yaml \
>       --do queue-get \
>       --json '{"ifindex": 4, "id": 15, "type": "rx"}'
>   {'id': 15,
>    'ifindex': 4,
>    'lease': {'ifindex': 8, 'netns-id': 0, 'queue': {'id': 1, 'type': 'rx'}},
>    'napi-id': 8227,
>    'type': 'rx',
>    'xsk': {}}
> 
>   # ip netns list
>   foo (id: 0)
> 
>   # ip netns exec foo ip a
>   [...]
>   8: nk@...E: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
>       link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
>       inet6 fe80::200:ff:fe00:0/64 scope link proto kernel_ll
>          valid_lft forever preferred_lft forever
>   [...]
> 
>   # ip netns exec foo ethtool -i nk
>   driver: netkit
>   [...]
> 
>   # ip netns exec foo ls /sys/class/net/nk/queues/
>   rx-0  rx-1  tx-0
> 
>   # ip netns exec foo ./pyynl/cli.py \
>       --spec ~/netlink/specs/netdev.yaml \
>       --do queue-get \
>       --json '{"ifindex": 8, "id": 1, "type": "rx"}'
>   {'id': 1, 'ifindex': 8, 'type': 'rx'}
> 
> Note that the caller of netdev_nl_queue_fill_one() holds the netdevice
> lock. For the queue-get we do not lock both devices. When queues get
> {un,}leased, both devices are locked, thus if __netif_get_rx_queue_peer()
> returns true, the peer pointer points to a valid device. The netns-id
> is fetched via peernet2id_alloc() similarly as done in OVS.
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Co-developed-by: David Wei <dw@...idwei.uk>
> Signed-off-by: David Wei <dw@...idwei.uk>
> Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>

Acked-by: Stanislav Fomichev <sdf@...ichev.me>