netdev - Re: [PATCH v4 net-next 01/10] net: introduce mangleid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88981dea-63b5-4e50-89ea-f4ad38314504@redhat.com>
Date: Tue, 20 Jan 2026 10:54:07 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Donald Hunter <donald.hunter@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, sdf@...ichev.me,
 petrm@...dia.com, razor@...ckwall.org, idosch@...dia.com
Subject: Re: [PATCH v4 net-next 01/10] net: introduce mangleid_features

On 1/20/26 9:58 AM, Eric Dumazet wrote:
> On Mon, Jan 19, 2026 at 4:10 PM Paolo Abeni <pabeni@...hat.com> wrote:
>> @@ -11385,6 +11385,12 @@ int register_netdevice(struct net_device *dev)
>>         if (dev->hw_enc_features & NETIF_F_TSO)
>>                 dev->hw_enc_features |= NETIF_F_TSO_MANGLEID;
>>
>> +       /* Any mangleid feature disables TSO_MANGLEID; including the latter
>> +        * in mangleid_features allows for better code in the fastpath.
>> +        */
>> +       if (dev->mangleid_features)
>> +               dev->mangleid_features |= NETIF_F_TSO_MANGLEID;
>> +
> 
> It is a bit unclear why you test for anything being set in mangleid_features
> 
> I would force here the bit, without any condition ?
> 
>       dev->mangleid_features |= NETIF_F_TSO_MANGLEID;

Indeed the check it's not needed. I'll drop it in the next revision, thanks!

Paolo