netdev - Re: [PATCH net-next] net: spacemit: Clarify stat timeout comments and messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f74cccd-4198-4a8a-92bb-4d4e6ae63e8d@lunn.ch>
Date: Tue, 20 Jan 2026 14:42:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vivian Wang <wangruikang@...as.ac.cn>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yixun Lan <dlan@...too.org>, Chukun Pan <amadeus@....edu.cn>,
	Michael Opdenacker <michael.opdenacker@...tcommit.com>,
	netdev@...r.kernel.org, linux-riscv@...ts.infradead.org,
	spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: spacemit: Clarify stat timeout comments
 and messages

On Tue, Jan 20, 2026 at 12:19:23PM +0800, Vivian Wang wrote:
> Someone did run into this timeout in the wild [1], and it turns out to
> be related to the PHY reference clock stopping.
> 
> Improve the comments and error message prints around this to reflect the
> better understanding of how this could happen. This patch doesn't fix
> the problem, but should direct anyone running into it in the future to
> know it is probably a PHY problem, and have a better idea what to do.
> 
> Link: https://lore.kernel.org/r/20260119141620.1318102-1-amadeus@jmu.edu.cn/ # [1]
> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>

It is not clear cut, but i think this could be useful in stable. It is
not actually fixing a problem which bothers people, which is the
criteria for stable, but it is pointing people towards the solution to
a problem which will bother people. And since it is mostly comments,
it is safe.

Please add a Fixes tag for when the driver was added, and base it on
net.

    Andrew

---
pw-bot: cr