netdev - [PATCH] net: fec: account for VLAN header in MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20260120160407.101273-1-mail@clemensgruber.at>
Date: Tue, 20 Jan 2026 17:04:07 +0100
From: Clemens Gruber <mail@...mensgruber.at>
To: netdev@...r.kernel.org
Cc: Shenwei Wang <shenwei.wang@....com>,
	Wei Fang <wei.fang@....com>,
	Jakub Kicinski <kuba@...nel.org>,
	imx@...ts.linux.dev,
	Clemens Gruber <mail@...mensgruber.at>,
	stable@...nel.org
Subject: [PATCH] net: fec: account for VLAN header in MAX_FL calculation

Commit 62b5bb7be7bc ("net: fec: update MAX_FL based on the current MTU")
changed the MAX_FL (maximum frame length) calculation without accounting
for VLAN-tagged frames, leading to RX errors / dropped frames.

Add VLAN_HLEN to the MAX_FL calculation.

Fixes: 62b5bb7be7bc ("net: fec: update MAX_FL based on the current MTU")

Signed-off-by: Clemens Gruber <mail@...mensgruber.at>
Cc: stable@...nel.org
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index e2b75d1970ae..f8f88c592323 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1151,7 +1151,7 @@ fec_restart(struct net_device *ndev)
 	u32 rcntl = FEC_RCR_MII;
 
 	if (OPT_ARCH_HAS_MAX_FL)
-		rcntl |= (fep->netdev->mtu + ETH_HLEN + ETH_FCS_LEN) << 16;
+		rcntl |= (fep->netdev->mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN) << 16;
 
 	if (fep->bufdesc_ex)
 		fec_ptp_save_state(fep);
-- 
2.52.0