[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADvbK_eUfuuwMg28nxo4g4+fLjJNrRDDWro8oape3uXu6GvoQA@mail.gmail.com>
Date: Tue, 20 Jan 2026 11:07:35 -0500
From: Xin Long <lucien.xin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: network dev <netdev@...r.kernel.org>, quic@...ts.linux.dev, davem@...emloft.net,
kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
Stefan Metzmacher <metze@...ba.org>, Moritz Buhl <mbuhl@...nbsd.org>, Tyler Fanelli <tfanelli@...hat.com>,
Pengtao He <hepengtao@...omi.com>, Thomas Dreibholz <dreibh@...ula.no>, linux-cifs@...r.kernel.org,
Steve French <smfrench@...il.com>, Namjae Jeon <linkinjeon@...nel.org>,
Paulo Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>, kernel-tls-handshake@...ts.linux.dev,
Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>,
Steve Dickson <steved@...hat.com>, Hannes Reinecke <hare@...e.de>, Alexander Aring <aahringo@...hat.com>,
David Howells <dhowells@...hat.com>, Matthieu Baerts <matttbe@...nel.org>,
John Ericson <mail@...nericson.me>, Cong Wang <xiyou.wangcong@...il.com>,
"D . Wythe" <alibuda@...ux.alibaba.com>, Jason Baron <jbaron@...mai.com>,
illiliti <illiliti@...tonmail.com>, Sabrina Dubroca <sd@...asysnail.net>,
Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Daniel Stenberg <daniel@...x.se>,
Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v7 15/16] quic: add packet builder base
On Tue, Jan 20, 2026 at 9:31 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 1/15/26 4:11 PM, Xin Long wrote:
> > +static struct sk_buff *quic_packet_handshake_create(struct sock *sk)
> > +{
> > + struct quic_packet *packet = quic_packet(sk);
> > + struct quic_frame *frame, *next;
> > +
> > + /* Free all frames for now, and future patches will implement the actual creation logic. */
> > + list_for_each_entry_safe(frame, next, &packet->frame_list, list) {
> > + list_del(&frame->list);
> > + quic_frame_put(frame);
>
> If you leave this function body empty and do the same for
> quic_packet_app_create(), you could additionally strip patch 14 from
> this series and avoid leaving several function defined there as unused.
>
I will give it a try, to move patch 14 to patchset-2.
Thanks.
Powered by blists - more mailing lists