netdev - Re: [PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izNS7cFxVbCQOTrsfNvqFCPm8ieu-vX+fMJ1rzLaK+C2SQ@mail.gmail.com>
Date: Tue, 20 Jan 2026 10:25:00 -0800
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org, 
	sdf@...ichev.me, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: fix missing include in ncdevmem

On Tue, Jan 20, 2026 at 10:03 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Commit ca9d74eb5f6a ("uapi: add INT_MAX and INT_MIN constants")
> recently removed some includes of limits.h in uAPI headers.
> ncdevmem.c was depending on them:
>
>   ncdevmem.c: In function ‘ethtool_add_flow’:
>   ncdevmem.c:369:60: error: ‘INT_MAX’ undeclared (first use in this function)
>   369 |         if (endptr == id_start || flow_id < 0 || flow_id > INT_MAX)
>       |                                                            ^~~~~~~
>   ncdevmem.c:77:1: note: ‘INT_MAX’ is defined in header ‘<limits.h>’; did you forget to ‘#include <limits.h>’?
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>



-- 
Thanks,
Mina