netdev - Re: [PATCH net-next V2 5/5] eth: fbnic: Update RX mbox timeout value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9096361-8f51-4865-af59-531649a5f42e@redhat.com>
Date: Tue, 20 Jan 2026 11:04:26 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Mohsin Bashir <mohsin.bashr@...il.com>, netdev@...r.kernel.org
Cc: alexanderduyck@...com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, horms@...nel.org, jacob.e.keller@...el.com,
 kernel-team@...a.com, kuba@...nel.org, lee@...ger.us,
 sanman.p211993@...il.com
Subject: Re: [PATCH net-next V2 5/5] eth: fbnic: Update RX mbox timeout value

On 1/15/26 1:33 AM, Mohsin Bashir wrote:
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> index b62b1d5b1453..f1c992f5fe94 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
> @@ -252,7 +252,7 @@ fbnic_flash_component(struct pldmfw *context,
>  		goto err_no_msg;
>  
>  	while (offset < size) {
> -		if (!wait_for_completion_timeout(&cmpl->done, 15 * HZ)) {

flash completion timeout was 15 secs

> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.h b/drivers/net/ethernet/meta/fbnic/fbnic_fw.h
> index 1ecd777aaada..b40f68187ad5 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.h
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.h
> @@ -36,6 +37,7 @@ struct fbnic_fw_mbx {
>   *                       + INDEX_SZ))
>   */
>  #define FBNIC_FW_MAX_LOG_HISTORY		14
> +#define FBNIC_MBX_RX_TO_SEC			10
>  
>  struct fbnic_fw_ver {
>  	u32 version;
> @@ -129,6 +131,13 @@ struct fbnic_fw_completion *__fbnic_fw_alloc_cmpl(u32 msg_type,
>  struct fbnic_fw_completion *fbnic_fw_alloc_cmpl(u32 msg_type);
>  void fbnic_fw_put_cmpl(struct fbnic_fw_completion *cmpl_data);
>  
> +static inline unsigned long
> +fbnic_mbx_wait_for_cmpl(struct fbnic_fw_completion *cmpl)
> +{
> +	return wait_for_completion_timeout(&cmpl->done,
> +					   FBNIC_MBX_RX_TO_SEC * HZ);

Timeout for all events is now 10 seconds. Is that intentional? Could
that cause unexpected timeout on flash update?

/P