netdev - Re: [PATCH net-next v2 1/5] printk: Add execution context (task name/CPU) to printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXC6MNOJidrYuSy0@gmail.com>
Date: Wed, 21 Jan 2026 03:41:49 -0800
From: Breno Leitao <leitao@...ian.org>
To: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, pmladek@...e.com, 
	john.ogness@...utronix.de
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Steven Rostedt <rostedt@...dmis.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	asantostc@...il.com, efault@....de, gustavold@...il.com, calvin@...nvd.org, 
	jv@...sburgh.net, mpdesouza@...e.com, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 1/5] printk: Add execution context (task
 name/CPU) to printk_info

On Tue, Jan 20, 2026 at 08:23:47AM -0800, Breno Leitao wrote:
> Extend struct printk_info to include the task name, pid, and CPU
> number where printk messages originate. This information is captured
> at vprintk_store() time and propagated through printk_message to
> nbcon_write_context, making it available to nbcon console drivers.
> 
> This is useful for consoles like netconsole that want to include
> execution context in their output, allowing correlation of messages
> with specific tasks and CPUs regardless of where the console driver
> actually runs.
> 
> The feature is controlled by CONFIG_PRINTK_EXECUTION_CTX, which is
> automatically selected by CONFIG_NETCONSOLE_DYNAMIC. When disabled,
> the helper functions compile to no-ops with no overhead.
> 
> Suggested-by: John Ogness <john.ogness@...utronix.de>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> ---
>  drivers/net/Kconfig               |  1 +
>  include/linux/console.h           |  8 ++++++
>  kernel/printk/internal.h          |  8 ++++++
>  kernel/printk/nbcon.c             | 15 +++++++++++
>  kernel/printk/printk.c            | 52 ++++++++++++++++++++++++++++++++++++++-
>  kernel/printk/printk_ringbuffer.h |  4 +++
>  lib/Kconfig.debug                 | 20 +++++++++++++++
>  7 files changed, 107 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index ac12eaf11755d..12e47cb27ffa5 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -341,6 +341,7 @@ config NETCONSOLE_DYNAMIC
>  	bool "Dynamic reconfiguration of logging targets"
>  	depends on NETCONSOLE && SYSFS && CONFIGFS_FS && \
>  			!(NETCONSOLE=y && CONFIGFS_FS=m)
> +	select CONSOLE_HAS_EXECUTION_CTX

This is wrong as detected by Kernel test robot.

	https://lore.kernel.org/all/202601211304.r9ecHy9L-lkp@intel.com/

On csky, CONSOLE_HAS_EXECUTION_CTX is set, but not
CONFIG_PRINTK_EXECUTION_CTX

	https://download.01.org/0day-ci/archive/20260121/202601211304.r9ecHy9L-lkp@intel.com/config

The execution context fields were not available, while
NETCONSOLE_DYNAMIC, causing a compilation error.

It needs to be:

+ select PRINTK_EXECUTION_CTX

--
pw-bot: cr