netdev - Re: Re: [net-next v7 5/8] net: wwan: add NMEA port support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXEEn4mcrUGj3Knb@horms.kernel.org>
Date: Wed, 21 Jan 2026 16:53:51 +0000
From: Simon Horman <horms@...nel.org>
To: Loic Poulain <loic.poulain@....qualcomm.com>
Cc: Slark Xiao <slark_xiao@....com>, ryazanov.s.a@...il.com,
	johannes@...solutions.net, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, mani@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Muhammad Nuzaihan <zaihan@...ealasia.net>,
	Qiang Yu <quic_qianyu@...cinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Johan Hovold <johan@...nel.org>
Subject: Re: Re: [net-next v7 5/8] net: wwan: add NMEA port support

On Wed, Jan 21, 2026 at 03:16:33PM +0100, Loic Poulain wrote:
> On Wed, Jan 21, 2026 at 3:09 AM Slark Xiao <slark_xiao@....com> wrote:
> >
> >
> >
> > At 2026-01-20 20:30:37, "Simon Horman" <horms@...nel.org> wrote:
> > >On Thu, Jan 15, 2026 at 07:46:22PM +0800, Slark Xiao wrote:
> > >
> > >...
> > >
> > >> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> > >
> > >...
> > >
> > >> +#else
> > >> +static inline int wwan_port_register_gnss(struct wwan_port *port)
> > >> +{
> > >> +    return -EOPNOTSUPP;
> > >> +}
> > >> +
> > >> +static inline void wwan_port_unregister_gnss(struct wwan_port *port)
> > >> +{
> > >> +    WARN_ON(1);     /* This handler cannot be called */
> > >> +}
> > >
> > >Please don't use the inline keyword in .c files unless there is a
> > >demonstrable - usually performance - reason to do so. Rather, let the
> > >compiler inline code as it sees fit.
> > >
> > >Using the inline keyword in .h is of course fine.
> > >
> > I think this shall be a mistake.
> > For a GNSS device, these 2 API shall not be called frequently.
> > So there is no necessary to add "inline" to improve performance.
> 
> Indeed, it's fine to remove that explicit inlines here.

Thanks!