netdev - Re: [PATCH net v3 2/7] net/sched: act_gate: add RCU support for parameter update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e58a29bc-3512-47ce-80cd-6c96a879c9cc@mojatatu.com>
Date: Wed, 21 Jan 2026 16:42:50 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Paul Moses <p@....org>, netdev@...r.kernel.org
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net v3 2/7] net/sched: act_gate: add RCU support for
 parameter update

On 21/01/2026 10:20, Paul Moses wrote:
> Make gact->param RCU-protected and reclaim old params via call_rcu(). This
> follows the pattern used by other actions: act_pedit swaps params with
> rcu_replace_pointer() and defers free via call_rcu() (commit 52cf89f78c01bf),
> act_connmark uses rcu_replace_pointer() under tcf_lock (commit 288864effe3388),
> and act_tunnel_key does the same under lockdep (commit 445d3749315f34).
> 
> Dump readers in act_ct and act_pedit already use rcu_read_lock() +
> rcu_dereference() (commits 554e66bad84ce4 and 9d096746572616), so act_gate
> must keep old params alive past updates as well.
> [...]

I think you could've transformed patches 2, 3, 4 into a single patch.
Since all of them are RCU-related changes and they sometimes overwrite
each other.