netdev - Re: [PATCH v2 03/16] bitmap: Use FIELD_PREP() in expansion of FIELD_PREP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121185903.201abe71@pumpkin>
Date: Wed, 21 Jan 2026 18:59:03 +0000
From: David Laight <david.laight.linux@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Yury Norov <yury.norov@...il.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org,
 linux-usb@...r.kernel.org, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Crt Mori <cmo@...exis.com>, Richard Genoud
 <richard.genoud@...tlin.com>, Andy Shevchenko
 <andriy.shevchenko@...el.com>, Luo Jie <quic_luoj@...cinc.com>, Peter
 Zijlstra <peterz@...radead.org>, Jakub Kicinski <kuba@...nel.org>,
 netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Mika
 Westerberg <mika.westerberg@...ux.intel.com>, Andreas Noever
 <andreas.noever@...il.com>, Yehezkel Bernat <YehezkelShB@...il.com>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Subject: Re: [PATCH v2 03/16] bitmap: Use FIELD_PREP() in expansion of
 FIELD_PREP_WM16()

On Wed, 21 Jan 2026 17:52:29 +0100
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> On Wed, 21 Jan 2026 at 17:50, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > On Fri, 12 Dec 2025 at 20:38, <david.laight.linux@...il.com> wrote:  
> > > From: David Laight <david.laight.linux@...il.com>
> > >
> > > Instead of directly expanding __BF_FIELD_CHECK() (which really ought
> > > not be used outside bitfield) and open-coding the generation of the
> > > masked value, just call FIELD_PREP() and add an extra check for
> > > the mask being at most 16 bits.
> > > The extra check is added after calling FIELD_PREP() to get a sane
> > > error message if 'mask' isn't constant.
> > >
> > > Remove the leading _ from the formal parameter names.
> > > Prefix the local variables with _wm16_ to hopefully make them
> > > unique.
> > >
> > > Signed-off-by: David Laight <david.laight.linux@...il.com>  
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>  
> 
> Oops, just noticed  commit 2fb6915fa22dc552
> ("compiler_types.h: add "auto" as a macro for "__auto_type""),
> so you want to do s/__auto_type/auto/g.

That wasn't there when I was writing the series.
I knew it was coming but didn't want build breakages.

	David

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>