[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7a43bedf-6d31-4ae1-b2c6-97cb3757ad9f@gmail.com>
Date: Wed, 21 Jan 2026 11:22:03 +0800
From: Joey Lu <a0987203069@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, krzk+dt@...nel.org, conor+dt@...nel.org,
mcoquelin.stm32@...il.com, richardcochran@...il.com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com, ychuang3@...oton.com,
schung@...oton.com, yclu4@...oton.com, peppe.cavallaro@...com,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
openbmc@...ts.ozlabs.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH net-next v8 1/3] dt-bindings: net: nuvoton: Add schema for
Nuvoton MA35 family GMAC
Rob Herring 於 1/21/2026 10:07 AM 寫道:
> On Mon, Jan 19, 2026 at 03:33:39PM +0800, Joey Lu wrote:
>> Create initial schema for Nuvoton MA35 family Gigabit MAC.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>> Signed-off-by: Joey Lu <a0987203069@...il.com>
>> ---
>> .../bindings/net/nuvoton,ma35d1-dwmac.yaml | 126 ++++++++++++++++++
>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
>> 2 files changed, 127 insertions(+)
>> create mode 100755 Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
> This should not be executable.
>
> Rob
Thanks for catching this.
I will fix the file mode in the next revision.
Joey
>> diff --git a/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
>> new file mode 100755
>> index 000000000000..8eaddfdc937c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
>> @@ -0,0 +1,126 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/nuvoton,ma35d1-dwmac.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Nuvoton DWMAC glue layer controller
>> +
>> +maintainers:
>> + - Joey Lu <yclu4@...oton.com>
>> +
>> +description:
>> + Nuvoton 10/100/1000Mbps Gigabit Ethernet MAC Controller is based on
>> + Synopsys DesignWare MAC (version 3.73a).
>> +
>> +allOf:
>> + - $ref: snps,dwmac.yaml#
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - nuvoton,ma35d1-dwmac
>> +
>> + reg:
>> + maxItems: 1
>> + description:
>> + Register range should be one of the GMAC interface.
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: MAC clock
>> + - description: PTP clock
>> +
>> + clock-names:
>> + items:
>> + - const: stmmaceth
>> + - const: ptp_ref
>> +
>> + nuvoton,sys:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + items:
>> + - items:
>> + - description: phandle to access syscon registers.
>> + - description: GMAC interface ID.
>> + enum:
>> + - 0
>> + - 1
>> + description:
>> + A phandle to the syscon with one argument that configures system registers
>> + for MA35D1's two GMACs. The argument specifies the GMAC interface ID.
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + items:
>> + - const: stmmaceth
>> +
>> + phy-mode:
>> + enum:
>> + - rmii
>> + - rgmii
>> + - rgmii-id
>> + - rgmii-txid
>> + - rgmii-rxid
>> +
>> + tx-internal-delay-ps:
>> + default: 0
>> + minimum: 0
>> + maximum: 2000
>> + description:
>> + RGMII TX path delay used only when PHY operates in RGMII mode with
>> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds.
>> + Allowed values are from 0 to 2000.
>> +
>> + rx-internal-delay-ps:
>> + default: 0
>> + minimum: 0
>> + maximum: 2000
>> + description:
>> + RGMII RX path delay used only when PHY operates in RGMII mode with
>> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds.
>> + Allowed values are from 0 to 2000.
>> +
>> +required:
>> + - clocks
>> + - clock-names
>> + - nuvoton,sys
>> + - resets
>> + - reset-names
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>> + #include <dt-bindings/reset/nuvoton,ma35d1-reset.h>
>> + ethernet@...20000 {
>> + compatible = "nuvoton,ma35d1-dwmac";
>> + reg = <0x40120000 0x10000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "macirq";
>> + clocks = <&clk EMAC0_GATE>, <&clk EPLL_DIV8>;
>> + clock-names = "stmmaceth", "ptp_ref";
>> +
>> + nuvoton,sys = <&sys 0>;
>> + resets = <&sys MA35D1_RESET_GMAC0>;
>> + reset-names = "stmmaceth";
>> +
>> + phy-mode = "rgmii-id";
>> + phy-handle = <ð_phy0>;
>> + mdio {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + eth_phy0: ethernet-phy@0 {
>> + reg = <0>;
>> + };
>> + };
>> + };
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index dd3c72e8363e..10cb5e555750 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -69,6 +69,7 @@ properties:
>> - ingenic,x2000-mac
>> - loongson,ls2k-dwmac
>> - loongson,ls7a-dwmac
>> + - nuvoton,ma35d1-dwmac
>> - nxp,s32g2-dwmac
>> - qcom,qcs404-ethqos
>> - qcom,sa8775p-ethqos
>> --
>> 2.43.0
>>
Powered by blists - more mailing lists