netdev - [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260122091527.339180-1-schalla@marvell.com>
Date: Thu, 22 Jan 2026 14:45:27 +0530
From: Srujana Challa <schalla@...vell.com>
To: <netdev@...r.kernel.org>, <virtualization@...ts.linux.dev>
CC: <pabeni@...hat.com>, <mst@...hat.com>, <jasowang@...hat.com>,
        <xuanzhuo@...ux.alibaba.com>, <eperezma@...hat.com>,
        <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <ndabilpuram@...vell.com>, <schalla@...vell.com>
Subject: [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY_LEN

Increase VIRTIO_NET_RSS_MAX_KEY_SIZE from 40 to 52 bytes to align with
the kernel's standard RSS key length defined by NETDEV_RSS_KEY_LEN.

The virtio specification requires devices to support at least 40 bytes
for the RSS key size. However, devices may support larger key sizes
up to 52 bytes (as reported by the device's rss_max_key_size config
field). This change allows such devices to work properly.
Previously, devices reporting rss_max_key_size > 40 would fail with
an error during initialization.

The driver already handles variable key sizes dynamically through
vi->rss_key_size, so increasing the maximum limit is safe and
maintains backward compatibility with devices that support smaller
key sizes.

Signed-off-by: Srujana Challa <schalla@...vell.com>
---
 drivers/net/virtio_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index db88dcaefb20..5f06cbc058d7 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -381,7 +381,7 @@ struct receive_queue {
 	struct xdp_buff **xsk_buffs;
 };

-#define VIRTIO_NET_RSS_MAX_KEY_SIZE     40
+#define VIRTIO_NET_RSS_MAX_KEY_SIZE     52

 /* Control VQ buffers: protected by the rtnl lock */
 struct control_buf {
-- 
2.25.1