netdev - Re: [net-next,V5,12/15] net/mlx5: Store QoS sched nodes in the sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f958d572454eb0e298660d2d713804692e77e16a.camel@nvidia.com>
Date: Thu, 22 Jan 2026 11:15:38 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "kuba@...nel.org" <kuba@...nel.org>
CC: "corbet@....net" <corbet@....net>, "rdunlap@...radead.org"
	<rdunlap@...radead.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"donald.hunter@...il.com" <donald.hunter@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "leon@...nel.org" <leon@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "jiri@...nulli.us" <jiri@...nulli.us>, Jiri Pirko
	<jiri@...dia.com>, Carolina Jubran <cjubran@...dia.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "horms@...nel.org"
	<horms@...nel.org>, Mark Bloch <mbloch@...dia.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "krzk@...nel.org"
	<krzk@...nel.org>, Saeed Mahameed <saeedm@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal Pressman
	<gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [net-next,V5,12/15] net/mlx5: Store QoS sched nodes in the
 sh_devlink

On Wed, 2026-01-21 at 19:40 -0800, Jakub Kicinski wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
> 
> This creates a bisect window between this commit and ef6db4a7f381
> where
> the QoS locking is broken. Could the setting of
> supported_cross_device_rate_nodes
> be moved into this patch to avoid the bisect issue?

This was a useful insight, and a clear 2-patch bisect window where
warnings would be generated.
I will merge the setting of supported_cross_device_rate_nodes with this
patch, since the mlx5 code is protected against cross-esw parents until
the next one in the series ("Support cross-device tx scheduling").

Cosmin.