netdev - Re: [PATCH] xfrm: force flush upon NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXIKwNJv59KnsnLw@secunet.com>
Date: Thu, 22 Jan 2026 12:32:16 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
CC: Boris Pismenny <borisp@...lanox.com>, "David S. Miller"
	<davem@...emloft.net>, Florian Westphal <fw@...len.de>, Kristian Evensen
	<kristian.evensen@...il.com>, Leon Romanovsky <leon@...nel.org>, Leon
 Romanovsky <leonro@...dia.com>, Raed Salem <raeds@...lanox.com>, Raed Salem
	<raeds@...dia.com>, Saeed Mahameed <saeedm@...lanox.com>, Yossi Kuperman
	<yossiku@...lanox.com>, Network Development <netdev@...r.kernel.org>,
	linux-security-module <linux-security-module@...r.kernel.org>, Aviad Yehezkel
	<aviadye@...dia.com>
Subject: Re: [PATCH] xfrm: force flush upon NETDEV_UNREGISTER event

On Thu, Jan 22, 2026 at 08:28:31PM +0900, Tetsuo Handa wrote:
> On 2026/01/22 20:15, Steffen Klassert wrote:
> > Hm, I'd say we should not try to offload to a device that does
> > not support NETIF_F_HW_ESP.
> 
> I was about to post the patch below, but you are suggesting that "do not allow calling
> xfrm_dev_state_add()/xfrm_dev_policy_add() if (dev->features & NETIF_F_HW_ESP) == 0" ?

As said, I think this is the correct way to do it. But let's wait
on opinions from the hardware people.