netdev - Re: [PATCH net v3 2/7] net/sched: act_gate: add RCU support for parameter update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <P2V-v-jfjb25y-nEIwKOu8x8N-xaC9avCsuZvL5B0RZRluny9zrE9htYN3bWaBX-XLb14bNJ0D-HaqgvKuk46IxtMaJ02-2_nv2ObmnAjBk=@1g4.org>
Date: Thu, 22 Jan 2026 15:51:30 +0000
From: Paul Moses <p@....org>
To: Victor Nogueira <victor@...atatu.com>
Cc: netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net v3 2/7] net/sched: act_gate: add RCU support for parameter update

Yes, wanted to show logical flow in this iteration. 

Thanks
Paul

On Wednesday, January 21st, 2026 at 1:42 PM, Victor Nogueira <victor@...atatu.com> wrote:

> 
> 
> On 21/01/2026 10:20, Paul Moses wrote:
> 
> > Make gact->param RCU-protected and reclaim old params via call_rcu(). This
> > follows the pattern used by other actions: act_pedit swaps params with
> > rcu_replace_pointer() and defers free via call_rcu() (commit 52cf89f78c01bf),
> > act_connmark uses rcu_replace_pointer() under tcf_lock (commit 288864effe3388),
> > and act_tunnel_key does the same under lockdep (commit 445d3749315f34).
> > 
> > Dump readers in act_ct and act_pedit already use rcu_read_lock() +
> > rcu_dereference() (commits 554e66bad84ce4 and 9d096746572616), so act_gate
> > must keep old params alive past updates as well.
> > [...]
> 
> 
> I think you could've transformed patches 2, 3, 4 into a single patch.
> Since all of them are RCU-related changes and they sometimes overwrite
> each other.