netdev - Re: [PATCH net-next 1/6] eth: bnxt: always set the queue mgmt ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260122163149.GA1545062@kernel-ep2>
Date: Thu, 22 Jan 2026 22:01:49 +0530
From: Subbaraya Sundeep <sbhatta@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
        <michael.chan@...adcom.com>, <sdf@...ichev.me>,
        <almasrymina@...gle.com>, <dtatulea@...dia.com>,
        <asml.silence@...il.com>, <dw@...idwei.uk>, <daniel@...earbox.net>
Subject: Re: [PATCH net-next 1/6] eth: bnxt: always set the queue mgmt ops

On 2026-01-22 at 21:06:43, Jakub Kicinski (kuba@...nel.org) wrote:
> On Thu, 22 Jan 2026 13:34:20 +0530 Subbaraya Sundeep wrote:
> > > +
> > > +	dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops_unsupp;
> > >  	if (BNXT_SUPPORTS_QUEUE_API(bp))
> > >  		dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
> > > -	dev->request_ops_lock = true;  
> > 
> > Can we also mention that driver with queue_mgmt_ops set makes it as ops locked
> > driver in Documentation/networking/netdevices.rst ?
> 
> Did you check if it's already documented there before asking me to do
> it? I know people don't read docs much but asking someone to document
> stuff that's already documented is a bit funny..

Okay it is there:

"Note that supporting struct netdev_queue_mgmt_ops automatically enables
"ops locking". "

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>

Thanks,
Sundeep