netdev - Re: [net-next,V5,10/15] net/mlx5: Add a shared devlink instance for PFs on same chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260121194135.6737b36f@kernel.org>
Date: Wed, 21 Jan 2026 19:41:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: tariqt@...dia.com
Cc: cratiu@...dia.com, saeedm@...dia.com, cjubran@...dia.com,
 davem@...emloft.net, horms@...nel.org, linux-doc@...r.kernel.org,
 mbloch@...dia.com, moshe@...dia.com, jiri@...dia.com, edumazet@...gle.com,
 gal@...dia.com, andrew+netdev@...n.ch, donald.hunter@...il.com,
 jiri@...nulli.us, krzk@...nel.org, pabeni@...hat.com,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org, rdunlap@...radead.org, leon@...nel.org,
 corbet@....net
Subject: Re: [net-next,V5,10/15] net/mlx5: Add a shared devlink instance for
 PFs on same chip

On Wed, 21 Jan 2026 19:39:59 -0800 Jakub Kicinski wrote:
> > +int mlx5_shd_init(struct mlx5_core_dev *dev)
> > +{
> > +	u8 *vpd_data __free(kfree) = NULL;  
> 
> The __free(kfree) annotation here combined with the early return below
> looks problematic.

__free() should be considered banned for netdev.
Please.
It clearly adds more bugs than it fixes.