netdev - Re: [PATCH v3 net-next 01/15] net/nebula-matrix: add minimum nbl build framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9026b5ab-c796-44c9-9b18-0e020e5c4397@infradead.org>
Date: Thu, 22 Jan 2026 17:31:16 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: "illusion.wang" <illusion.wang@...ula-matrix.com>,
 dimon.zhao@...ula-matrix.com, alvin.wang@...ula-matrix.com,
 sam.chen@...ula-matrix.com, netdev@...r.kernel.org
Cc: andrew+netdev@...n.ch, corbet@....net, kuba@...nel.org,
 linux-doc@...r.kernel.org, lorenzo@...nel.org, pabeni@...hat.com,
 horms@...nel.org, vadim.fedorenko@...ux.dev, lukas.bulwahn@...hat.com,
 hawk@...nel.org, ast@...nel.org, bpf@...r.kernel.org, sdf@...ichev.me,
 daniel@...earbox.net, john.fastabend@...il.com, edumazet@...gle.com,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 01/15] net/nebula-matrix: add minimum nbl
 build framework

Hi--

On 1/22/26 5:17 PM, illusion.wang wrote:
> diff --git a/drivers/net/ethernet/nebula-matrix/Kconfig b/drivers/net/ethernet/nebula-matrix/Kconfig
> new file mode 100644
> index 000000000000..14c27c63d7ec
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/Kconfig
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Nebula-matrix network device configuration
> +#
> +
> +config NET_VENDOR_NEBULA_MATRIX
> +    bool "Nebula-matrix devices"
> +    default y
> +    help
> +      If you have a network (Ethernet) card belonging to this class, say Y.
> +
> +      Note that the answer to this question doesn't directly affect the
> +      kernel: saying N will just cause the configurator to skip all
> +      the questions about Nebula-matrix cards. If you say Y, you will be
> +      asked for your specific card in the following questions.
> +
> +if NET_VENDOR_NEBULA_MATRIX
> +
> +config NBL_CORE
> +    tristate "Nebula-matrix Ethernet Controller m18100 Family support"
> +    depends on 64BIT && PCI
> +    default m
> +    select PAGE_POOL
> +    help
> +      This driver supports Nebula-matrix Ethernet Controller m18100 Family of
> +      devices.  For more information about this product, go to the product
> +      description with smart NIC:
> +
> +      <http://www.nebula-matrix.com>
> +
> +      More specific information on configuring the driver is in
> +      <file:Documentation/networking/device_drivers/ethernet/nebula-matrix/m18100.rst>.
> +
> +      To compile this driver as a module, choose M here. The module
> +      will be called nbl_core.
> +
> +endif # NET_VENDOR_NEBULA_MATRIX

There are lots of spaces used here for indentation.

Please see Documentation/process/coding-style.rst, section
10) Kconfig configuration files, for the correct indentation style
for Kconfig files.


-- 
~Randy