[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c77a150a-4ad6-4765-9852-ce5e3408c29e@iscas.ac.cn>
Date: Fri, 23 Jan 2026 10:10:40 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: Andrew Lunn <andrew@...n.ch>, Chukun Pan <amadeus@....edu.cn>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, dlan@...nel.org,
edumazet@...gle.com, kuba@...nel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, netdev@...r.kernel.org, pabeni@...hat.com,
spacemit@...ts.linux.dev
Subject: Re: [PATCH 1/1] net: spacemit: display phy driver information
On 1/22/26 23:18, Andrew Lunn wrote:
> On Thu, Jan 22, 2026 at 11:06:01PM +0800, Chukun Pan wrote:
>> Hi,
>>
>>>> Print the PHY driver used and interrupt status after connection.
>>> The standard way to do this is call phy_attached_info(). Is it missing
>>> some information you need?
>> I initially used phy_attached_info(), but it was too long and printed
>> phydev_name() "cac80000.ethernet:01" twice:
>>
>> YT8531 Gigabit Ethernet cac80000.ethernet:01: attached PHY driver (mii_bus:phy_addr=cac80000.ethernet:01, irq=POLL)
> This is what everybody expects, so you should use it.
>
> You have some control over the names, it is the name you assign when
> creating the struct device. Maybe you can shorten them.
Right... it's just copied from the name of the platform device itself,
which is AFAICT a common approach.
Honestly I think the name doesn't need shortening. The K1 has two of
these MACs, so it needs the identifying information. And at least to me
the platform device name "cac80000.ethernet" is pretty recognizable.
Vivian "dramforever" Wang
Powered by blists - more mailing lists