netdev - Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260123181156.GA84531@bhelgaas>
Date: Fri, 23 Jan 2026 12:11:56 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-s390@...r.kernel.org, rust-for-linux@...r.kernel.org,
	Jon Mason <jdmason@...zu.us>, Jonathan Corbet <corbet@....net>,
	Linas Vepstas <linasvepstas@...il.com>,
	Mahesh J Salgaonkar <mahesh@...ux.ibm.com>,
	Oliver O'Halloran <oohall@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@...nel.org>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Danilo Krummrich <dakr@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Martin Kepplinger-Novaković <martink@...teo.de>,
	Pavel Machek <pavel@....cz>, MD Danish Anwar <danishanwar@...com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Huacai Chen <chenhuacai@...nel.org>, Theodore Ts'o <tytso@....edu>,
	Takashi Iwai <tiwai@...e.de>, Eric Biggers <ebiggers@...gle.com>,
	Madadi Vineeth Reddy <vineethr@...ux.ibm.com>,
	Ard Biesheuvel <ardb@...nel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Frederic Barrat <fbarrat@...ux.ibm.com>,
	Andrew Donnellan <ajd@...ux.ibm.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Dong Yibo <dong100@...se.com>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Vivian Wang <wangruikang@...as.ac.cn>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused
 driver

On Thu, Jan 22, 2026 at 07:30:41PM -0800, Ethan Nelson-Moore wrote:

> ... Remove the driver, and move the former maintainer
> to the CREDITS file (restoring credit for the vxge driver, which was
> removed in commit f05643a0f60b ("eth: remove neterion/vxge").

>  include/linux/pci_ids.h                       |    6 -

Not sure there's value in removing the IDs from pci_ids.h.  It may
lead to unnecessary conflicts later for stable and other backports.

> +++ b/include/linux/pci_ids.h
> @@ -2445,12 +2445,6 @@
>  #define PCI_DEVICE_ID_ARECA_1680	0x1680
>  #define PCI_DEVICE_ID_ARECA_1681	0x1681
>  
> -#define PCI_VENDOR_ID_S2IO		0x17d5
> -#define	PCI_DEVICE_ID_S2IO_WIN		0x5731
> -#define	PCI_DEVICE_ID_S2IO_UNI		0x5831
> -#define PCI_DEVICE_ID_HERC_WIN		0x5732
> -#define PCI_DEVICE_ID_HERC_UNI		0x5832
> -
>  #define PCI_VENDOR_ID_SITECOM		0x182d
>  #define PCI_DEVICE_ID_SITECOM_DC105V2	0x3069