netdev - Re: [PATCH net-next] net: usb: sr9700: use ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tswcrt7d.fsf@dell.be.48ers.dk>
Date: Fri, 23 Jan 2026 21:04:54 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org,  linux-usb@...r.kernel.org,  Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] net: usb: sr9700: use ETH_ALEN instead of
 magic number

>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@...il.com> writes:

 > The driver hardcodes the number 6 as the number of bytes to write to
 > the SR_PAR register, which stores the MAC address. Use ETH_ALEN instead
 > to make the code clearer.

 > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>

Reviewed-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard