netdev - Re: [PATCH v2 net] mptcp: fix race in mptcp_pm_nl_flush_addrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9255c8f1-713d-4a04-80bc-da856b8f9c71@kernel.org>
Date: Sat, 24 Jan 2026 12:17:25 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Mat Martineau <martineau@...nel.org>, Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Geliang Tang <geliang.tang@...ux.dev>,
 Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, eric.dumazet@...il.com,
 syzbot+5498a510ff9de39d37da@...kaller.appspotmail.com,
 Eulgyu Kim <eulgyukim@....ac.kr>, Geliang Tang <geliang@...nel.org>
Subject: Re: [PATCH v2 net] mptcp: fix race in mptcp_pm_nl_flush_addrs_doit()

Hi Mat, Eric,

On 23/01/2026 22:43, Mat Martineau wrote:
> On Fri, 23 Jan 2026, Eric Dumazet wrote:
> 
>> syzbot and Eulgyu Kim reported crashes in mptcp_pm_nl_get_local_id()
>> and/or mptcp_pm_nl_is_backup()
>>
>> Root cause is list_splice_init() in mptcp_pm_nl_flush_addrs_doit()
>> which is not RCU ready.
>>
>> list_splice_init_rcu() can not be called here while holding pernet->lock
>> spinlock.
>>
>> Many thanks to Eulgyu Kim for providing a repro and testing our patches.
>>
>> Fixes: 141694df6573 ("mptcp: remove address when netlink flushes addrs")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Reported-by: syzbot+5498a510ff9de39d37da@...kaller.appspotmail.com
>> Closes: https://lore.kernel.org/
>> all/6970a46d.a00a0220.3ad28e.5cf0.GAE@...gle.com/T/
>> Reported-by: Eulgyu Kim <eulgyukim@....ac.kr>
>> Cc: Geliang Tang <geliang@...nel.org>
>> ---
>> v2: Make sure the list was not empty, return early otherwise.
> 
> Thanks Eric, the v2 code changes LGTM.

Thank you for the patch and the review!

> The netdev tooling wasn't able to
> apply the patch (https://patchwork.kernel.org/project/netdevbpf/
> patch/20260123030327.3041148-1-edumazet@...gle.com/), so Matthieu is
> planning to send a basically-identical v3 that 'git am' and the netdev
> CI will be happy with.

Just did:

https://lore.kernel.org/20260124-net-mptcp-race_nl_flush_addrs-v3-1-b2dc1b613e9d@kernel.org

I guess we need to manually update Patchwork if the sender is different:

pw-bot: superseded

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.