netdev - Re: [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64f626f4-5432-4335-b6aa-af74b49b4a5e@kernel.org>
Date: Sun, 25 Jan 2026 19:35:59 -0700
From: David Ahern <dsahern@...nel.org>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
 Ido Schimmel <idosch@...dia.com>, Jiri Pirko <jiri@...nulli.us>
Cc: Breno Leitao <leitao@...ian.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering
 slave

On 1/25/26 7:35 AM, Tetsuo Handa wrote:
> syzbot is reporting
> @@ -1330,7 +1330,13 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
>  	__team_port_change_port_removed(port);
>  
>  	team_port_set_orig_dev_addr(port);
> -	dev_set_mtu(port_dev, port->orig.mtu);
> +	if (unregister) {
> +		netdev_lock_ops(port_dev);
> +		__netif_set_mtu(port_dev, port->orig.mtu);
> +		netdev_unlock_ops(port_dev);
> +	} else {
> +		dev_set_mtu(port_dev, port->orig.mtu);
> +	}
>  	kfree_rcu(port, rcu);
>  	netdev_info(dev, "Port device %s removed\n", portname);
>  	netdev_compute_master_upper_features(team->dev, true);

same logic as bonding, so a netdev based helper that both drivers can use?