netdev - Re: [PATCH net-next v2 4/7] net: openvswitch: fix load tearing with u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1fdd80c-e93b-4c48-a354-af560dae3368@ovn.org>
Date: Mon, 26 Jan 2026 13:25:50 +0100
From: Ilya Maximets <i.maximets@....org>
To: David Yang <mmyangfl@...il.com>, netdev@...r.kernel.org
Cc: i.maximets@....org, Aaron Conole <aconole@...hat.com>,
 Eelco Chaudron <echaudro@...hat.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, dev@...nvswitch.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/7] net: openvswitch: fix load tearing with
 u64_stats

On 1/23/26 5:21 PM, David Yang wrote:
> On 64bit arches, struct u64_stats_sync is empty and provides no help
> against load/store tearing. struct copying should not be considered
> tear-free. Use u64_stats_reads() instead.
> 
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
>  net/openvswitch/datapath.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index d5b6e2002bc1..8ba94df7f942 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -770,7 +770,8 @@ static void get_dp_stats(const struct datapath *dp, struct ovs_dp_stats *stats,
>  
>  		do {
>  			start = u64_stats_fetch_begin(&percpu_stats->syncp);
> -			local_stats = *percpu_stats;
> +			u64_stats_reads(&local_stats, percpu_stats,
> +					sizeof(local_stats));

I suppose, you'll either need to use offset of 'syncp' field here,
or copy fields one by one, which is not great.

Best regards, Ilya Maximets.

>  		} while (u64_stats_fetch_retry(&percpu_stats->syncp, start));
>  
>  		stats->n_hit += local_stats.n_hit;